Skip to content

Shankara/pcl include fix#221

Merged
shankarapailoor merged 2 commits intomainfrom
shankara/pcl-include-fix
Nov 21, 2025
Merged

Shankara/pcl include fix#221
shankarapailoor merged 2 commits intomainfrom
shankara/pcl-include-fix

Conversation

@shankarapailoor
Copy link
Contributor

Used the wrong variable when guarding pcl imports.

@shankarapailoor shankarapailoor requested a review from a team November 21, 2025 16:55
@shankarapailoor shankarapailoor merged commit dc2fe94 into main Nov 21, 2025
10 checks passed
raghav198 pushed a commit that referenced this pull request Nov 21, 2025
* used the wrong cmake flag when guarding PCL imports
raghav198 added a commit that referenced this pull request Dec 9, 2025
* Registered new transformation pass

* Concatenation pass works

* deleted comments

* Basic inlining complete

* Fixed issue calling @Product

* Refactoring, added root-struct option

* Aligning subfunctions

* Refactor to make struct inlining available on demand (#212)

* For now, fail when we can't align some calls

* [NFC] Refactor inline structs pass to prepare for handling more "remaining uses" (#218)

* add debug output, clarify docs, fix typos
* refactoring to prepare for handling more "remaining uses"
* update debug output with new function names

* Brought back LightweightSignalEquivalenceAnalysis

* Added testcase

* Shankara/pcl include fix (#221)

* used the wrong cmake flag when guarding PCL imports

* Added libAnalysis to CMake

* Removed libAnalysis from CMake

* Namespacing

* Namespacing

* Put analysis back

* Link `LLZKAnalysis` in `LLZKTransforms` (#225)

also explicitly link LLZKDialect in the dialects that use it to fix linker error that surfaced as a result

* remove redundant "add_dependencies" from cmake (#226)

* clang-format

* Changelog

* FORMAT

* Addressing comments

* update manual build instructions to build clang dependency

* Addressing comments

* Add missing headers to `llzk-tblgen` lib (#239)

* Refactor to add calleeContainsWitnessGen() and getSingleResultTypeOfWitnessGen() instead of overloading ...Compute()

* nit

* revert

---------

Co-authored-by: Raghav Malik <raghav@veridise.com>
Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
Co-authored-by: shankarapailoor <shankarapailoor@gmail.com>
Co-authored-by: Tim Hoffman <timothy.hoffman@veridise.com>
@tim-hoffman tim-hoffman deleted the shankara/pcl-include-fix branch March 3, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants